[chore] Implement is_auto_partitioned method in table.rs #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beryllw
force-pushed
the
auto-partitioned
branch
from
dd36fca to
8dcd531
Compare
Contributor
Author
|
@luoyuxia cc |
There was a problem hiding this comment.
Pull request overview
This PR implements the is_auto_partitioned method in table.rs which was previously marked with a todo!(). The implementation introduces a new AutoPartitionStrategy struct to parse and manage auto-partition configuration from table properties, and uses it to determine whether a table has auto-partitioning enabled.
Changes:
- Added
AutoPartitionStrategystruct with methods to parse auto-partition configuration from properties - Implemented
is_auto_partitionedmethod that checks both partitioning and auto-partition enablement - Added comprehensive test coverage for all scenarios
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
luoyuxia
approved these changes
Jan 27, 2026
Contributor
|
@beryllw Please rebase main branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #45
Brief change log
Tests
API and Format
Documentation